[
https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248055#comment-15248055
]
James E. King, III commented on THRIFT-3233:
--------------------------------------------
I agree removeWorker is not functioning properly. In my investigation into
THRIFT-3768 I was planning to use the call in an implementation but it proved
to be unsafe. The patch does not cover all issues in the code. I'll take a
look.
> Fix ThreadManager::Impl::removeWorker worker join
> -------------------------------------------------
>
> Key: THRIFT-3233
> URL: https://issues.apache.org/jira/browse/THRIFT-3233
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: Paweł Janicki
> Priority: Critical
> Attachments:
> 0001-THRIFT-3233.-cpp-Fix-ThreadManager-Impl-removeWorker.patch
>
>
> ThreadManager::Impl::removeWorker is not joining worker properly.
> It possible that the not joined worker will continue to reference destructed
> ThreadManager's non-static members causing crash.
> It is caused by removeWorker() implementation which waits for workers to
> decrement the ThreadManager's workerCount_. Once value is decremented
> removeWorker() assumes the worker thread joined, while in fact the worker
> thread continues to execute some more code which adds the worker thread to
> destruction list which list may be just freed due to ThreadManager object
> destruction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
