[
https://issues.apache.org/jira/browse/THRIFT-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268003#comment-15268003
]
Hudson commented on THRIFT-3803:
--------------------------------
SUCCESS: Integrated in Thrift-precommit #451 (See
[https://builds.apache.org/job/Thrift-precommit/451/])
THRIFT-3803 - Remove file attribute from include elements in XML (jensg:
[https://github.com/apache/thrift/commit/ea0da97d44d1f9e367303c66cc55e825ed419260])
* lib/xml/thrift-idl.xsd
* compiler/cpp/src/generate/t_xml_generator.cc
> Remove "file" attribute from XML generator
> ------------------------------------------
>
> Key: THRIFT-3803
> URL: https://issues.apache.org/jira/browse/THRIFT-3803
> Project: Thrift
> Issue Type: Improvement
> Components: XML/XSD - Compiler
> Affects Versions: 0.10.0
> Reporter: Benjamin Gould
> Assignee: Benjamin Gould
> Priority: Minor
> Fix For: 0.10.0
>
>
> When I created the XML generator, I added an attribute named "file" to the
> <include /> element that has path information to the included file.
> The information being exported into the XML file however is an absolute path
> that is specific to the system on which the XML file is generated, which
> probably should not exported. Additionally, I'm not sure that the path
> information has much particular use anyhow, so IMO this should just be
> removed (especially since it has not been in an official release yet).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)