[
https://issues.apache.org/jira/browse/THRIFT-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
winterland updated THRIFT-3837:
-------------------------------
Description:
QuickCheck 2.8.2 provide Arbitrary instance for Map and Set from containers
already, this change result in failure of building thrift with:
```
src/Thrift/Arbitraries.hs:29:10:
Duplicate instance declarations:
instance (Ord k, Arbitrary k, Arbitrary v) => Arbitrary (Map k v)
-- Defined at src/Thrift/Arbitraries.hs:29:10
instance [safe] (Ord k, Arbitrary k, Arbitrary v) =>
Arbitrary (Map k v)
-- Defined in ‘Test.QuickCheck.Arbitrary’
src/Thrift/Arbitraries.hs:32:10:
Duplicate instance declarations:
instance (Ord k, Arbitrary k) => Arbitrary (Set.Set k)
-- Defined at src/Thrift/Arbitraries.hs:32:10
instance [safe] (Ord a, Arbitrary a) => Arbitrary (Set.Set a)
-- Defined in ‘Test.QuickCheck.Arbitrary’
```
Same thing happened for unordered-containers package where Hashable instance
are defined from 0.2.6 version.
A version constraint <2.8.2 on QuickCheck and <0.2.6 on unordered-containers
should be added to thrift's cabal, this can be done using hackage's
revision(editing cabal file without upload a new tarball), maintainer please do
this!
was:
QuickCheck 2.8.2 provide Arbitrary instance for Map and Set from containers
already, this change result in failure of building thrift with:
```
src/Thrift/Arbitraries.hs:29:10:
Duplicate instance declarations:
instance (Ord k, Arbitrary k, Arbitrary v) => Arbitrary (Map k v)
-- Defined at src/Thrift/Arbitraries.hs:29:10
instance [safe] (Ord k, Arbitrary k, Arbitrary v) =>
Arbitrary (Map k v)
-- Defined in ‘Test.QuickCheck.Arbitrary’
src/Thrift/Arbitraries.hs:32:10:
Duplicate instance declarations:
instance (Ord k, Arbitrary k) => Arbitrary (Set.Set k)
-- Defined at src/Thrift/Arbitraries.hs:32:10
instance [safe] (Ord a, Arbitrary a) => Arbitrary (Set.Set a)
-- Defined in ‘Test.QuickCheck.Arbitrary’
```
A version constraint <2.8.2 on QuickCheck should be added to thrift's cabal,
this can be done using hackage's revision(editing cabal file without upload a
new tarball), maintainer please do this!
Summary: Thift 0.9.3 can't be build with QuickCheck 2.8.2 and
unordered-containers 0.2.6 (was: Thift 0.9.3 can't be build with QuickCheck
2.8.2)
> Thift 0.9.3 can't be build with QuickCheck 2.8.2 and unordered-containers
> 0.2.6
> -------------------------------------------------------------------------------
>
> Key: THRIFT-3837
> URL: https://issues.apache.org/jira/browse/THRIFT-3837
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.9.3
> Reporter: winterland
> Labels: build
> Fix For: 0.10.0
>
>
> QuickCheck 2.8.2 provide Arbitrary instance for Map and Set from containers
> already, this change result in failure of building thrift with:
> ```
> src/Thrift/Arbitraries.hs:29:10:
> Duplicate instance declarations:
> instance (Ord k, Arbitrary k, Arbitrary v) => Arbitrary (Map k v)
> -- Defined at src/Thrift/Arbitraries.hs:29:10
> instance [safe] (Ord k, Arbitrary k, Arbitrary v) =>
> Arbitrary (Map k v)
> -- Defined in ‘Test.QuickCheck.Arbitrary’
> src/Thrift/Arbitraries.hs:32:10:
> Duplicate instance declarations:
> instance (Ord k, Arbitrary k) => Arbitrary (Set.Set k)
> -- Defined at src/Thrift/Arbitraries.hs:32:10
> instance [safe] (Ord a, Arbitrary a) => Arbitrary (Set.Set a)
> -- Defined in ‘Test.QuickCheck.Arbitrary’
> ```
> Same thing happened for unordered-containers package where Hashable instance
> are defined from 0.2.6 version.
> A version constraint <2.8.2 on QuickCheck and <0.2.6 on unordered-containers
> should be added to thrift's cabal, this can be done using hackage's
> revision(editing cabal file without upload a new tarball), maintainer please
> do this!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
