[
https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302232#comment-15302232
]
Steve Cohen commented on THRIFT-3834:
-------------------------------------
[~jensg], that's not true, erlang didn't *support* namespaces before this
change and ignored the namespace * line. This change allowed it to support
namespaces and the tests failed because the records suddenly became namespaced.
You can view this in one of two ways:
* The testing IDL's usage of namespace * is wrong, since each binding should
determine which namespace its modules live in.
* The erlang unit tests were incorrect because the testing idl used namespace
* and the tests didn't assert that the records they used were in the proper
namespace.
Personally, I think tests and testing code should be very explicit, and
namespace * isn't explicit at all, and wasn't set by anyone who knows/cares
anything about the erlang bindings. However, I've updated the tests so that
they use the proper namespace.
Maybe I'm not up on thrift, but we have hundreds of idl files and none of them
have namespace * in them.
> Erlang namespacing and exception metadata
> -----------------------------------------
>
> Key: THRIFT-3834
> URL: https://issues.apache.org/jira/browse/THRIFT-3834
> Project: Thrift
> Issue Type: New Feature
> Components: Erlang - Compiler
> Reporter: Steve Cohen
> Assignee: Steve Cohen
> Fix For: 0.10.0
>
> Attachments: thrift-3834-erlang_metadata_fixed_tests.patch
>
>
> The erlang modules generated by thrift cannot be namespaced, this change
> allows namespacing like in other thrift types.
> If Module A defines a struct S and Module B defines a struct S and Module A
> includes Module B, it will not compile. This change fixes that problem.
> If at all possible, I'd like this to get into 0.10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
