Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1023#discussion_r65980877
--- Diff: lib/dart/lib/src/transport/t_buffered_transport.dart ---
@@ -22,13 +22,13 @@ class TBufferedTransport extends TTransport {
final List<int> _writeBuffer = [];
Iterator<int> _readIterator;
- Uint8List _consumeWriteBuffer() {
+ Uint8List consumeWriteBuffer() {
Uint8List buffer = new Uint8List.fromList(_writeBuffer);
_writeBuffer.clear();
return buffer;
}
- void _setReadBuffer(Uint8List readBuffer) {
+ void setReadBuffer(Uint8List readBuffer) {
--- End diff --
I don't think you need to change the visibility of this method here and in
all of the subclasses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
