Currently JIRA patches need manual verification that can to be error prone and/or tedious. It would make much sense to either enable the JIRA-patch-Jenkins integration or stop accepting JIRA patches. The latter seems reasonable to me, for the sake of simplicity and focus.
On Sat, Jun 11, 2016 at 3:36 AM Jens Geyer <[email protected]> wrote: > > For small patches github is very time consuming, compared to the actual > patch. But OTOH having a working process that pre-checks all commits is a > highly useful tool w/regard to quality. I personally think that quality > outweights comfort. I'm for it given we have a reliably working solution. I > don't see the benefit if that is not the case. > > Have fun, > JensG > ________________________________ > Von: Jake Farrell > Gesendet: 10.06.2016 19:41 > An: [email protected] > Betreff: Re: [DISCUSS] Disable Github -> Jenkins pull request hook > > Not all pull requests come through github and Jenkins allowed for us to be > able to add a patch to master and test it without having to touch github at > all. The github-jenkins integration is a hook which we can disable at > anytime without impacting jira integration, as long as a ticket id is in > the github issue then the github hook will comment on the jira issue on > update, though pass/fail build result will not be added to the ticket for > that patch. Appvoyer and other build systems have not been integrated will > not comment on the jira tickets. > > The question I would pose is do we want to use github for all code review > and patch submissions as the only option for contributions to Apache Thrift > ? > > -Jake > > > > > > On Thu, Jun 9, 2016 at 11:13 PM, Aki Sukegawa <[email protected]> wrote: > > > Hi, > > > > Our Jenkins build has been dead for a while now. > > The thing is that the job is only a subset of Travis-CI jobs. > > So we can proceed just fine with Travis-CI and Appveyor without losing > any > > test case. > > > > To be clear, our Jenkins build has not been sufficient alone during > recent > > years. > > On the other hand the Travis-CI build covers more cases and contains what > > the Jenkins job currently does. > > > > If there's no concerns, I'll request Apache infra team for removal of our > > Github-Jenkins integration, on their JIRA. > > Thought ? > > >
