[
https://issues.apache.org/jira/browse/THRIFT-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343240#comment-15343240
]
ASF GitHub Bot commented on THRIFT-3476:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1032
THRIFT-3476: fix missing header
stdexcept was missing, but std::runtime_error is used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1032
----
commit 3201a1d97b7aa09d1d0b5f3f12cd865080f7f97e
Author: Jim King <[email protected]>
Date: 2016-06-19T23:46:01Z
THRIFT-3476: fix missing header
----
> Missing include in ./src/thrift/protocol/TJSONProtocol.cpp
> ----------------------------------------------------------
>
> Key: THRIFT-3476
> URL: https://issues.apache.org/jira/browse/THRIFT-3476
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Environment: Using built-in specs.
> COLLECT_GCC=g++
> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.7/lto-wrapper
> Target: x86_64-linux-gnu
> Configured with: ../src/configure -v --with-pkgversion='Debian 4.7.2-5'
> --with-bugurl=file:///usr/share/doc/gcc-4.7/README.Bugs
> --enable-languages=c,c++,go,fortran,objc,obj-c++ --prefix=/usr
> --program-suffix=-4.7 --enable-shared --enable-linker-build-id
> --with-system-zlib --libexecdir=/usr/lib --without-included-gettext
> --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.7
> --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
> --enable-libstdcxx-debug --enable-libstdcxx-time=yes
> --enable-gnu-unique-object --enable-plugin --enable-objc-gc
> --with-arch-32=i586 --with-tune=generic --enable-checking=release
> --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
> Thread model: posix
> gcc version 4.7.2 (Debian 4.7.2-5)
> Reporter: Martin Werner
> Assignee: James E. King, III
> Priority: Minor
>
> CPP library did not compile due to not finding std::runtime_error as
> #include<stdexcept> is missing at the beginning of this file...
> Too simple for a patch ;-)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
