All the pull requests that I have outstanding are not critical, so if you decide to package up 0.10.0 based on master today it will have everything in it that I feel needed to be fixed in the C++ library. As such I changed the last two critical severity issues to major in the C++ backlog, and there are no criticals in the perl backlog.
-----Original Message----- From: Aki Sukegawa [mailto:[email protected]] Sent: Monday, July 11, 2016 12:27 PM To: [email protected] Subject: Re: 0.10.0 Jim, most of them are submitted after initial planned date of 0.10.0 release that is January. I believe it is more important to proceed with the next release right now. That said, I agree we need to work through pull requests. I've written while ago a small tool to list all pull requests which have closed JIRA tickets or no ticket, so maybe we can ask Apache INFRA team (or maybe directly Jake ?) to close them at once later. John, FWIW CI works for the current master, so it's more about how it looks. I understand bad looking CI result = less contributors and it needs to be fixed eventually, but I don't think we should delay the release even further for this. About the contributing advice, which part you find outdated ? Maybe we can remove JIRA-patch part, as it seems that many of us are liking Github PR. On Tue, Jul 12, 2016 at 1:02 AM John Sirois <[email protected]> wrote: > I'm excited to see progress towards a sane state for contributors to > pile on, but, in addition to Jim's point, I have a few concerns: > + Which build is the pre-commit? The master CI looks ~75% red: > https://travis-ci.org/apache/thrift/builds - still dauntingly red for > a new contributor imo. > + Is the contributing advice still accurate?: > https://thrift.apache.org/docs/HowToContribute > > On Mon, Jul 11, 2016 at 9:47 AM, Jim King <[email protected]> wrote: > > > I suggested to Jake in an email that we should drain the pull > > request > list > > before we do this. There are 110+ open pull requests on github. > > That > size > > backlog is not healthy. Anything recent that can be rebased and > > merged should be included. Anything older than a couple months > > should probably > be > > declined outright and the author may resubmit it. > > > > - Jim > > > > -----Original Message----- > > From: Aki Sukegawa [mailto:[email protected]] > > Sent: Monday, July 11, 2016 5:14 AM > > To: [email protected] > > Subject: Re: 0.10.0 > > > > +1 ! > > > > On Mon, Jul 11, 2016, 17:07 Jens Geyer <[email protected]> wrote: > > > > > +1 > > > ________________________________ > > > Von: Jake Farrell > > > Gesendet: 11.07.2016 04:02 > > > An: [email protected] > > > Betreff: 0.10.0 > > > > > > With the builds now solely on travis and the pre-commit green > > > again what are peoples thoughts on cutting 0.10.0, any objections? > > > > > > -Jake > > > > > > > > ---------------------------------------------------------------------- > ----------------- > > PRIVACY STATEMENT: > > This message is a PRIVATE communication. This message and all > attachments > > are a private communication sent by SimpliVity and are considered to > > be confidential or protected by privilege. If you are not the > > intended recipient, you are hereby notified that any disclosure, > > copying, distribution or use of the information contained in or > > attached to this message is strictly prohibited. Please notify the > > sender of the delivery error by replying to this message, and then delete > > it from your system. > > > > > ---------------------------------------------------------------------- > ----------------- > > > --------------------------------------------------------------------------------------- PRIVACY STATEMENT: This message is a PRIVATE communication. This message and all attachments are a private communication sent by SimpliVity and are considered to be confidential or protected by privilege. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the information contained in or attached to this message is strictly prohibited. Please notify the sender of the delivery error by replying to this message, and then delete it from your system. ---------------------------------------------------------------------------------------
