GitHub user binaryseed opened a pull request:
https://github.com/apache/thrift/pull/1049
Fix erlang compact protocol boolean representation
I've noticed that when using the compact protocol in `erlang`, the boolean
flags are inverted.
It appears the we've simply defined the constants wrong. For reference,
here are a few other languages which appear to constantly define `true` as
`0x01` and `false` as `0x02`:
*
https://github.com/apache/thrift/blob/master/lib/rb/lib/thrift/protocol/compact_protocol.rb#L36-L37
*
https://github.com/apache/thrift/blob/master/lib/py/src/protocol/TCompactProtocol.py#L84-L85
*
https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java#L101-L102
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/binaryseed/thrift fix-erl-bool-compact
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1049.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1049
----
commit 067440f83e746f13906c05c8eeed31c5e33e9dbc
Author: Vince Foley <[email protected]>
Date: 2016-07-14T21:21:00Z
Fix erlang compact protocol boolean representation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
