Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1039#discussion_r71078534
--- Diff: compiler/cpp/test/plugin/conversion_test.cc ---
@@ -269,6 +268,8 @@ void test_const_value(t_const_value* sut) {
#undef T_CONST_VALUE_CASE
case t_const_value::CV_MAP:
BOOST_CHECK_EQUAL(sut->get_map().size(), sut2->get_map().size());
+ // NOTE This test only works with map with a single entry because we
can't
+ // rely on map ordering with pointers as key.
BOOST_CHECK_EQUAL(sut->get_map().begin()->first->get_type(),
sut2->get_map().begin()->first->get_type());
BOOST_CHECK_EQUAL(sut->get_map().begin()->second->get_type(),
--- End diff --
I think we still want to have multiple values inside map, e.g. by using
`operator[]`/`find` on sut2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
