[
https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383837#comment-15383837
]
ASF GitHub Bot commented on THRIFT-2835:
----------------------------------------
Github user dtmuller commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1039#discussion_r71299569
--- Diff: compiler/cpp/src/plugin/plugin.cc ---
@@ -402,6 +402,13 @@ THRIFT_CONVERSION(t_program, from.path, from.name) {
boost::for_each(from.services |
boost::adaptors::transformed(&resolve_service),
boost::bind(&::t_program::add_service, to, _1));
+ for (std::vector<t_program>::const_iterator it = from.includes.begin();
+ it != from.includes.end();
+ it++) {
+ ::t_program* tmp = new ::t_program((*it).path, (*it).name);
+ convert<t_program, ::t_program>((*it), tmp);
+ to->add_include(tmp);
+ }
--- End diff --
Just stumbled over another thing: the `t_program::includes_` were empty on
the plugin side...
> Add possibility to distribute generators separately from thrift core, and
> load them dynamically
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2835
> URL: https://issues.apache.org/jira/browse/THRIFT-2835
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Anatol Pomozov
> Labels: fbthrift
>
> It is a follow-up for discussion with Facebook's fbthrift
> https://github.com/facebook/fbthrift/issues/48
> fbthrift adds its own generator that creates C++ classes based on their
> libraries. I do not know how upstreamable this generator but I think other
> companies would want to do the same - create their own custom generators.
> Currently there is no way to distribute generators separately from the thrift
> core. Thus the company have to fork whole project and add their own
> generator. It is what Facebook did.
> The idea is that thrift should be able to load language generators
> dynamically. i.e. a company foo creates its own generator and puts it to
> system /usr/lib/thrift/generators/cpp_foo.so When thrift compiler starts - it
> checks /usr/lib/thrift/generators/ and uses dlopen() to load the shared
> libraries. The shared library contains information about the generator (name,
> options, ...) thus it allows thrift core to use this custom third-party
> generator.
> This allows companies to create and distribute generator will less pain and
> no need to fork the project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
