[
https://issues.apache.org/jira/browse/THRIFT-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390966#comment-15390966
]
ASF GitHub Bot commented on THRIFT-3885:
----------------------------------------
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1052
Also I noticed that `if (true)` part below inside the existing function
seems completely redundant.
`else` code even uses different set of variables.
We can clean it up without losing any value, right ?
> PHP: Error when readI64 in TCompactProtocol
> -------------------------------------------
>
> Key: THRIFT-3885
> URL: https://issues.apache.org/jira/browse/THRIFT-3885
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.7, 0.8, 0.9, 0.9.1, 0.9.2, 0.9.3
> Environment: all
> Reporter: Chen Zhiming
> Labels: patch
>
> In line 618 of readI64 of TCompactProtocol, the number of shift bit is error.
> It must be
> $hi |= (($byte & 0x7f) >> (7 - ($shift - 25)));
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
