Github user udit043 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1057#discussion_r73373066
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -471,8 +471,10 @@ void TSSLSocket::checkHandshake() {
}
} while (rc == 2);
} else {
- // set the SNI hostname
- SSL_set_tlsext_host_name(ssl_, getHost().c_str());
+ /* OpenSSL < 0.9.8f does not have SSL_set_tlsext_host_name() */
+ #if defined(SSL_set_tlsext_host_name) // set the SNI hostname
--- End diff --
I have created a issue regarding this:
https://issues.apache.org/jira/browse/THRIFT-3892
No, there is not any alternative for older version. There are very less
possibilities of someone using very old OpenSSL library. This issue is
negligible, it is just for improving the project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
