[ 
https://issues.apache.org/jira/browse/THRIFT-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406461#comment-15406461
 ] 

James E. King, III commented on THRIFT-3892:
--------------------------------------------

[~jensg] please review this change to ensure you agree with the preprocessor 
branch logic and don't want to do anything more fancy like checking the OpenSSL 
version that is set in the build environment, or set up something like 
configure would to check if a system has sscanf_r() [for example] to detect 
whether this API is accessible or not.

> Thrift uses TLS SNI extension provided by OpenSSL library. Older version of 
> OpenSSL(< 0.9.8f) may create problem because they do not support 
> 'SSL_set_tlsext_host_name()'.
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3892
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3892
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>            Reporter: Udit Raikwar
>            Priority: Trivial
>              Labels: newbie
>
> Thrift uses TLS SNI extension during SSL handshake provided by OpenSSL 
> library. Older version of OpenSSL(< 0.9.8f) may create problem because they 
> do not support 'SSL_set_tlsext_host_name()'.
> I have created a pull request regarding this issue[1], this issue is although 
> negligible because all newer version of OpenSSL supports TLS SNI extension 
> but checking if TLS SNI extension is supported in user's OpenSSL version is 
> not bad.
> [1]=https://github.com/apache/thrift/pull/1057



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to