Github user nsuke commented on the issue:

    https://github.com/apache/thrift/pull/930
  
    @gadLinux locking, indent and cmake changes look good !
    Only concern is the test dependency on external service.
    One way to avoid it is to use cpp for server side as in 
`lib/c_glib/test/testthrifttestclient.cpp`.
    
    Also could you enable `test/c_glib/src/test_client.c` to initialize your 
SSL implementation with `--ssl` option ?
    We'll be able to add this to our cross language tests then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to