John  created THRIFT-3920:
-----------------------------

             Summary: Ruby: Ensuring that HTTP failures will clear the http 
transport outbuf var
                 Key: THRIFT-3920
                 URL: https://issues.apache.org/jira/browse/THRIFT-3920
             Project: Thrift
          Issue Type: Bug
          Components: Ruby - Library
    Affects Versions: 0.9.3
            Reporter: John 


PR: https://github.com/apache/thrift/pull/1048


With the current implementation, any Net HTTP failure will raise from the 
#flush() method without resetting the @outbuf variable.

I think that resetting the @outbuf on these failures is more "expected" 
behaviour. Especially if there is a malformed request that the downstream 
server does not want to/can't handle. As far as I can tell, there is not way to 
clear the @outbuf var apart from the #flush() method, so if that fails, then 
you will just keep appending requests to the out buffer.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to