[ 
https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471280#comment-15471280
 ] 

ASF GitHub Bot commented on THRIFT-3921:
----------------------------------------

GitHub user viveksjain opened a pull request:

    https://github.com/apache/thrift/pull/1083

    THRIFT-3921 Add C++ ostream operator<< functions for enums

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viveksjain/thrift THRIFT-3921

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1083
    
----
commit 570717279501ab1c0184ab76b93b8b35abae2914
Author: Vivek Jain <[email protected]>
Date:   2016-09-07T17:34:25Z

    THRIFT-3921 Add C++ ostream operator<< functions for enums

----


> C++ code should print enums as strings
> --------------------------------------
>
>                 Key: THRIFT-3921
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3921
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>            Reporter: Vivek Jain
>
> THRIFT-2067 added {{operator<<}} to the C++ generated code, which is great, 
> but enums are printed as numbers rather than their string representation. It 
> would be great if the generated code printed them as a string instead. There 
> might be some backwards-compatibility concerns (if users have already defined 
> their own versions, then thrift's version would cause compile errors), not 
> sure how important you guys think those are.
> Other thoughts/concerns? I am willing to work on a patch if no one else is 
> able to work on it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to