GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1087
THRIFT-3927 Emitting an error instead of throwing in the async callback Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error should be the correct way to handle the errors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lifei/thrift fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 ---- commit f0b1d5eaf3a6ae7d006edda26cf0c13df524d044 Author: lifei <lifei....@outlook.com> Date: 2016-09-14T10:18:32Z THRIFT-3927 Emit an error instead of throw an error in the async callback ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---