[ 
https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506760#comment-15506760
 ] 

Vadrot Romain commented on THRIFT-3928:
---------------------------------------

The proposed patch is a good start but is not complete as it does not generate 
implementation of assignment operator for result objects.

It seems something went wrong. 
In 0.9.0:
* default constructor was declared and implemented,
* copy constructor and assignment operator were not declared (so generated by 
compiler)
* setters were declared and implemented.

Now in 0.9.3:
* default constructor is declared and implemented,
* copy constructor and assignment operator are declared and not implemented (so 
not generated by compiler), so link error when used
* setters are declared and not implemented, so link error when used

> CPP generator doesn`t generate implementations of constructors, operators and 
> setters for function helpers
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3928
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3928
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Denis 
>              Labels: easyfix
>         Attachments: thrift_cpp_generator.patch
>
>
> cpp generator  doesn`t  generate implementations of constructors, operators  
> for function and service helpers in *Service.cpp 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to