Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80308235
--- Diff: compiler/cpp/src/generate/t_php_generator.cc ---
@@ -1720,6 +1720,7 @@ void
t_php_generator::generate_service_client(t_service* tservice) {
<< "TBinaryProtocolAccelerated) &&
function_exists('thrift_protocol_write_binary');"
<< endl;
+ f_service_client << indent() << "$this->seqid_ = rand();" << endl;
f_service_client << indent() << "if ($bin_accel)" << endl;
--- End diff --
I'm not quite sure what that ```rand()``` should do here? The sequential
number is expected to be sequential. I would be a bit surprised when a function
called ```rand()``` starts to return sequential numbers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
