Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1094#discussion_r80392522
  
    --- Diff: lib/go/thrift/simple_server.go ---
    @@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client 
TTransport) error {
                        log.Printf("error processing request: %s", err)
                        return err
                }
    -           if err, ok := err.(TApplicationException); ok && err.TypeId() 
== UNKNOWN_METHOD {
    -                   continue
    -           }
    --- End diff --
    
    I would doubt that. If that is true that would probably qualify for a bug 
report. I would not expect a formatting tool to arbitrarily delete valid code 
lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to