[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521462#comment-15521462
]
ASF GitHub Bot commented on THRIFT-3855:
----------------------------------------
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80392646
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client
TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId()
== UNKNOWN_METHOD {
- continue
- }
--- End diff --
@Jens-G Reverted back that change. Thank you for review!
> In the go simple server, if Stop() is called multiple times it hangs
> --------------------------------------------------------------------
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
> Fix For: 0.10.0
>
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
