Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1101#discussion_r81464809
--- Diff: build/cmake/DefineOptions.cmake ---
@@ -164,31 +164,36 @@ message(STATUS "Thrift package version:
${PACKAGE_VERSION}
message(STATUS "Build configuration Summary")
message(STATUS " Build Thrift compiler:
${BUILD_COMPILER}")
message(STATUS " Build compiler plugin support:
${WITH_PLUGIN}")
+if (WITH_PLUGIN_COMPILER_TOO_OLD)
+ MESSAGE_DEP(WITH_PLUGIN "Disabled due to older compiler")
+else()
+ MESSAGE_DEP(WITH_PLUGIN "Disabled by WITH_PLUGIN=OFF")
--- End diff --
Unfortunately, due to WITH_PLUGIN flag's existing flaw, it's not always
true.
(Should have separate BUILD_PLUGIN flag).
As it's not relevant to this patch, removing this would suffice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
