GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/1111
THRIFT-3546: Remove global namespace objects from nodejs generated code
Modified the node.js code generator to not generate namespace object by
default, as using require() is the idiomatic way to reference classes contained
in other modules for node, instead of relying on a object heirarchy existing in
the global namespace.
This change makes the generated code work under Javascript's "use strict"
mode.
In case others are relying on the existing behavior, I added a ":with_ns"
flag to the compiler that enables the current behavior for backwards
compatibility.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgould/thrift THRIFT-3546
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1111
----
commit 10d11d733bfec328b94e1a3d70675f67cbc44312
Author: BCG <[email protected]>
Date: 2016-10-05T14:25:27Z
Removed namespace objects from nodejs generated code, and added with_ns
option for backwards compatibility.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
