Hey Ben THRIFT-2527 is in the 0.10.0 release candidate branch, 3rd commit in the log from HEAD with commit hash 548403eeab40ca8c8217fce2dade26876b41b152
-Jake On Tue, Oct 11, 2016 at 10:55 AM, BCG <bgo...@hushmail.com> wrote: > On 10/11/2016 09:45 AM, BCG wrote: > >> On 10/11/2016 09:23 AM, Jake Farrell wrote: >> >>> Morning everyone >>> I have a working 0.10.0 release candidate [1] which is now passing all >>> tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been >>> closed as well. Are there any final patches we want to see make it in, if >>> not then I plan on branching, package and start the release candidate >>> vote >>> later this week >>> >>> -Jake >>> >>> >>> >>> Hi Jake >> >> I'd like to see THRIFT-3546 make it in, I have an open PR on github >> (#1111) with tests passing. This patch makes it possible to use >> "browserified" node.js code even with "use strict" mode in the browser, and >> also makes the generated code compatible with the "babel" compiler. >> Additionally my patch resolves THRIFT-3735 if I am not mistaken. >> >> https://issues.apache.org/jira/browse/THRIFT-3546 >> >> Thanks >> >> Ben >> >> >> Also if possible I would like to request github PR #1112... this was > already merged onto master a few days back. I didn't notice initially that > it wasn't on your release candidate branch. These are small style changes > to pass jshint, no changes to functionality. > > https://issues.apache.org/jira/browse/THRIFT-2527 > > Thanks again > > Ben > >
