[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565712#comment-15565712
]
Patrick Bennett commented on THRIFT-3855:
-----------------------------------------
I just modified the generated .go code and got it working fine. It's a very
trivial patch (add that Close line). I'm just surprised no one noticed this
before? No one tried to stop an idle server?
I was never able to get thrift building cleanly locally with the solutions or
cmake generated files and vc14 (vs2015) so I can't test the changes locally for
submitting a patch. If I stay with thrift I may go back to it in earnest. So
far the performance is about 4-5x slower than grpc (although grpc seems
completely broken for ruby/windows clients so thrift is only working solution
for me at the moment).
> In the go simple server, if Stop() is called multiple times it hangs
> --------------------------------------------------------------------
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Assignee: Paul Finkelshteyn
> Priority: Minor
> Fix For: 0.10.0
>
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
