[ 
https://issues.apache.org/jira/browse/THRIFT-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577704#comment-15577704
 ] 

Jens Geyer commented on THRIFT-3946:
------------------------------------

The patch file is UCS-2 encoded, which git refuses to handle. 
Manually converting to UTF-8 does not help either, it does not apply to master:

{code}
$ git apply ../thrift-3946-java5-binary-arrays-copyof.patch
error: patch failed: compiler/cpp/src/thrift/generate/t_java_generator.cc:447
error: compiler/cpp/src/thrift/generate/t_java_generator.cc: patch does not 
apply
{code}






> Java 1.5 compatibility broken for binary fields (java5 option)
> --------------------------------------------------------------
>
>                 Key: THRIFT-3946
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3946
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Philip Hamer
>              Labels: java5
>         Attachments: thrift-3946-java5-binary-arrays-copyof.patch
>
>
> For binary fields, even with the java5 option (--gen java:java5), generated 
> code uses "Arrays.copyOf", which is only available in Java 1.6+.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to