[
https://issues.apache.org/jira/browse/THRIFT-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651974#comment-15651974
]
James E. King, III commented on THRIFT-3965:
--------------------------------------------
[~jfarrell], [~jensg] There have been a number of issues in the pre-canned
visual studio projects. They get stale with respect to code changes and
nothing in CI builds them. They only support the version of the IDE that they
were made for. In contrast, CMake is able to always generate a MSVC solution
tailored to a specific version of the IDE and will never be stale with respect
to the project because we use it in our CI environment for builds.
Therefore I am recommending that we remove the pre-canned visual studio
solution files from the project and provide detailed instructions for folks to
use CMake to generate a project solution for Thrift when they need something
for Windows. I've been doing this build customization a lot lately with
another project so I have all the bits & pieces that I need to put together
some instructions for this. You can refer to THRIFT-3832 as another example of
issues in this area.
> VisualStudio project cannot build compiler CPP project
> ------------------------------------------------------
>
> Key: THRIFT-3965
> URL: https://issues.apache.org/jira/browse/THRIFT-3965
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: Microsoft Visual Studio Enterprise 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Enterprise
> Architecture and Modeling Tools 00322-80000-00000-AA924
> Microsoft Architecture and Modeling Tools
>
> UML® and Unified Modeling Language™ are trademarks or registered trademarks
> of the Object Management Group, Inc. in the United States and other countries.
> Visual Basic 2015 00322-80000-00000-AA924
> Microsoft Visual Basic 2015
> Visual C# 2015 00322-80000-00000-AA924
> Microsoft Visual C# 2015
> Visual C++ 2015 00322-80000-00000-AA924
> Microsoft Visual C++ 2015
> Application Insights Tools for Visual Studio Package 5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8) 14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2 4.1.41102.0
> For additional information, visit
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013 5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools 1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure
> Tools.
> JavaScript Language Service 2.0
> JavaScript Language Service
> JavaScript Project System 2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools 1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager 3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet,
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer 1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the
> PreEmptive Analytics product.
> SQL Server Data Tools 14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript 1.8.31.0
> TypeScript tools for Visual Studio
> Reporter: Gary Gregory
> Assignee: James E. King, III
> Labels: Windows
>
> Based on the current git master branch.
> The project's {{t_generator.h}} want to use the header file {{version.h}}:
> {code}
> #include "thrift/version.h"
> {code}
> The file does not exist but {{version.h.in}} is there and looks to be
> expected by the CMake build's {{CMakeLists.txt}}:
> {code}
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
> ${CMAKE_CURRENT_BINARY_DIR}/thrift/version.h)
> {code}
> As a workaround I just copied {{version.h.in}} to {{version.h}}.
> It would be nice to fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
