[
https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665865#comment-15665865
]
Aki Sukegawa commented on THRIFT-3828:
--------------------------------------
[~jking3] Looks like github comment edits do not come down here.
I'm using CMake 3.6.3.
According to [an upstream bug
report|https://gitlab.kitware.com/cmake/cmake/issues/16291]:
{quote}
This didn't break the 99% of the standard builds (...) But when cross-compiling
or when using a non-default system include directory, the build breaks.
{quote}
[~codyps] are you cross compiling or using non-default system includes ?
As to the workaround, I think we should avoid removing SYSTEM as much as we
can, since it can lead to bloated warnings from external library headers.
WebKit project conceived a workaround for this without removing SYSTEM.
http://trac.webkit.org/changeset/205672/trunk/Source/cmake/OptionsCommon.cmake
https://bugs.webkit.org/show_bug.cgi?id=161697
> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to
> include_directories()) is empty
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3828
> URL: https://issues.apache.org/jira/browse/THRIFT-3828
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Cody Schafer
> Assignee: James E. King, III
> Priority: Minor
> Attachments:
> 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to
> `include_directories()`. These variables may (and soon will, see below) be
> empty in the case where the include directory is a system include path that
> is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't
> work with includes that are part of the platform/system include path (see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To
> resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types
> of directories to Boost_INCLUDE_DIRS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
