Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88559811
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -60,7 +60,7 @@
#endif // _WIN32
#endif
-#if defined(_WIN32) && (_WIN32_WINNT < 0x0600)
+#if defined(_WIN32) && (_WIN32_WINNT < 0x0600) && !defined(AI_ADDRCONFIG)
#define AI_ADDRCONFIG 0x0400
--- End diff --
I'm not convinced this needs to be defined here; every windows platform
windows supports has winsock2, which includes ws2def.h, which defines this and
AI_PASSIVE which is used right alongside AI_ADDRCONFIG in the code... so I am
going to remove the #if block here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
