[
https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fei Dong updated THRIFT-3984:
-----------------------------
Description:
I cant offer a script to reproduce segfault because it not happens everytime.
PHP7 extension use ZVAL_STR to convert zend_string to zval struct，and later use
zval_dtor try to free it.
https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L825
The method_name parameter is pass from PHP script, and zval_dtor decrement the
gc reference count, thus would free the zend_string object but it is still
referenced in the script.
I changed ZVAL_STR to ZVAL_STR_COPY, which will add reference count by 1 to
the zend_string object , apply this patch in our production environment and
segfault never happen again
Another place use ZVAL_STR is
[here|https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L668].
Both this two place need to be fixed
was:
I cant offer a script to reproduce segfault because it not happens everytime.
PHP7 extension use ZVAL_STR to convert zend_string to zval struct，and later use
zval_dtor try to free it.
https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L825
The method_name parameter is pass from PHP script, and zval_dtor decrement the
gc reference count, thus would free the zend_string object but it is still
referenced in the script.
I tried to change ZVAL_STR to ZVAL_STR_COPY, which will add reference count by
1 to the zend_string object.
We have apply this patch in our production environment and segfault never
happen again
Another place use ZVAL_STR is
[here|https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L668].
Both this two place need to be fixed
> PHP7 extenstion cause segfault
> ------------------------------
>
> Key: THRIFT-3984
> URL: https://issues.apache.org/jira/browse/THRIFT-3984
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Reporter: Fei Dong
> Priority: Critical
>
> I cant offer a script to reproduce segfault because it not happens
> everytime.
> PHP7 extension use ZVAL_STR to convert zend_string to zval struct，and later
> use zval_dtor try to free it.
> https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L825
> The method_name parameter is pass from PHP script, and zval_dtor decrement
> the gc reference count, thus would free the zend_string object but it is
> still referenced in the script.
> I changed ZVAL_STR to ZVAL_STR_COPY, which will add reference count by 1 to
> the zend_string object , apply this patch in our production environment and
> segfault never happen again
> Another place use ZVAL_STR is
> [here|https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp#L668].
> Both this two place need to be fixed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
