Ooops. My bad - "Jens" not "Jen". So sorry for the misspelling :( Terminal Musings: http://www.allengeorge.com/ Raft in Java: https://github.com/allengeorge/libraft/ Twitter: https://twitter.com/allenageorge/
On Wed, Dec 7, 2016 at 10:48 PM, Allen George <[email protected]> wrote: > Hi Jen, > > Ah. That makes sense. Absolutely - I'd be happy to toss up a PR in the > next few days. > > Allen > Terminal Musings: http://www.allengeorge.com/ > Raft in Java: https://github.com/allengeorge/libraft/ > Twitter: https://twitter.com/allenageorge/ > > > On Wed, Dec 7, 2016 at 3:09 AM, Jens Geyer <[email protected]> wrote: >> Hi George, >> >> good question. Main reason is very likely because a) they were added later >> and b) they work a lot like structs. >> >> Nevertheless you are absolutely right, they should be, as they are a core >> part of the language. Would you mind adding them and some test cases in one >> or two languages of your choice? That would be awesome. Having that, we can >> start integrating those test cases in all other languages. >> >> @Aki, Jake & Roger: That will very likely break the Test suite until all >> languages are properly covered. How can we handle this? Feature branch >> maybe? >> >> Have fun, >> JensG >> >> >> -----Ursprüngliche Nachricht----- >> From: Allen George >> Sent: Wednesday, December 7, 2016 12:09 AM >> To: [email protected] >> Subject: Why are there no unions in ThriftTest.thrift? >> >> It seems like a lot of other cases are covered, and unions seem like a >> surprising omission. Why is that? I also notice that includes (and so, >> namespaced-types) are not there as well. >> >> Thanks, >> Allen >>
