[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833017#comment-15833017
]
James E. King, III commented on THRIFT-3013:
--------------------------------------------
I understand where folks are coming from, so thank you for the responses
regarding boost.
The reason why I hesitate going with a checked-in solution file is that when
the C++ library changes, people will need to update the solution/project as
well. If the solution is generated every time, it is always correct and we
eliminate a bunch of tickets (there are at least 3). Especially since we don't
use the static project in the CI build, nothing would verify it still works. I
think it also makes sense for the project to provide a thrift.exe official
binary, statically linked with static runtime so there are no dependencies. We
can cover the project stuff in the other ticket for cmake / windows build
projects (THRIFT-3973).
As for this, given the solution is there (I agree with Randy, would like to see
the use of program-options-like options i.e. "-r" or "--recurse"), let's get a
pull request into github so CI can validate it, and make sure we have a test
that executes the new code.
> make thrift compiler accept a list of input files
> -------------------------------------------------
>
> Key: THRIFT-3013
> URL: https://issues.apache.org/jira/browse/THRIFT-3013
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Affects Versions: 0.9.2
> Reporter: Xiaoshuang LU
> Assignee: Roger Meier
> Attachments: THRIFT-3013.v4.patch
>
>
> At present, customers could only specify one input file to thrift compiler.
> There are maybe two approaches to support multiple input files.
> Approach 1: Improve the option parser in compiler/cpp/src/main.cc. Maybe we
> can borrow code from GUN's getopt_long.
> Approach 2: Offer users a maven plugin which can help them to iterate through
> a list of input files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
