[
https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833079#comment-15833079
]
ASF GitHub Bot commented on THRIFT-3973:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1162#discussion_r97203001
--- Diff: build/wincpp/build-thrift-compiler.bat ---
@@ -0,0 +1,80 @@
+::
+:: Licensed under the Apache License, Version 2.0 (the "License");
+:: you may not use this file except in compliance with the License.
+:: You may obtain a copy of the License at
+::
+:: http://www.apache.org/licenses/LICENSE-2.0
+::
+:: Unless required by applicable law or agreed to in writing, software
+:: distributed under the License is distributed on an "AS IS" BASIS,
+:: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+:: See the License for the specific language governing permissions and
+:: limitations under the License.
+::
+
+::
+:: Produces a production thrift compiler suitable for redistribution.
+:: The compiler is linked to runtime statically for maximum portability.
+:: Assumes the thirdparty files for "winflexbison" have been placed
+:: according to the README.md instructions.
+::
+:: Open a Visual Studio Command Prompt of your choosing and then
+:: run this script.
+
+@ECHO OFF
+SETLOCAL EnableDelayedExpansion
+
+IF NOT DEFINED CMAKE_ROOT SET CMAKE_ROOT=C:\Program Files\CMake
--- End diff --
I need to remove this, since it can confuse CMAKE. We'll assume that CMAKE
is in the path, like the other top level batch does. With this here I was
getting errors with CMAKE-3.7 so I will fix in the next push.
> Remove MSVC C++ projects to improve maintainability; document building Thrift
> on Windows using CMake to generate project files
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3973
> URL: https://issues.apache.org/jira/browse/THRIFT-3973
> Project: Thrift
> Issue Type: Story
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> A class of issues has popped up where the project files checked into the
> project have become stale and/or the instructions for building on windows
> need to be updated.
> These issues are linked to this item. The purpose of this story is to
> eliminate these issues by getting rid of the project files checked into the
> project for windows (C++ specifically) and to update the web site
> documentation on how to build the thrift libraries for windows (native, not
> MinGW - those instructions will remain as-is).
> Acceptance Criteria:
> # Instructions for, and supporting tools (if any) are provided by the
> project. This must include support for:
> ## Compiler executable builds in debug and release form
> ## Static library builds in debug and release form (due to DLL export issues,
> windows builds do not support dynamic library generation today)
> ## Support for optional library support like zlib, libevent, boost, std
> (threads)
> ## Support for MSVC 2010 or later
> ## Support for CMake 3.6 or later
> # MSVC project files for C++ are removed from the project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
