Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97843055
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
Yes, this is a breaking change which was originally discussed in
THRIFT-4011; I only started working on this PR after I was given the go ahead.
> How will this be communicated?
I would imagine posts to the mailing lists and an announcement on the
website, several weeks in advance of a new release?
> What happens to existing handlers that implement the older method?
Compiling IDLs with this patch will change the signature of any RPC or
struct in the generated Go code, so it's very easy to catch at compile time and
make the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
