[
https://issues.apache.org/jira/browse/THRIFT-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859058#comment-15859058
]
ASF GitHub Bot commented on THRIFT-4073:
----------------------------------------
GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/1182
THRIFT-4073 enum files are still being generated with unused imports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgould/thrift THRIFT-4073
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1182
----
commit 9e3f77b9b8aa88c9530ed13f63ed71e47b738efe
Author: BCG <[email protected]>
Date: 2017-02-09T05:31:42Z
removed imports from generated enums
----
> enum files are still being generated with unused imports
> --------------------------------------------------------
>
> Key: THRIFT-4073
> URL: https://issues.apache.org/jira/browse/THRIFT-4073
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.10.0
> Reporter: Christopher Tubbs
>
> I love that import statements are no longer being generated, because it means
> less "unused imports" warnings from my compiler and checkstyle rules.
> However, it appears that the enum generation did not get as much care as
> class file generation. There still remain some import statements in enum
> files. All of them are unused because of the fully-qualified types being used
> instead, so they are safe to delete.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
