[
https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863726#comment-15863726
]
ASF GitHub Bot commented on THRIFT-4084:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1185
My guess is that the python tests are no longer correct, or the method of
making python use SSLv23 in the code we merged is wrong. What I would suggest
is backing out the last patch db9ac77f1e9c01ae57a9c6df48cb8670e9045ebb which
changed the python stuff. I have cherry picked that into THRIFT-4084 which I
am working on so you can drop it. I will send you another PR shortly which
eliminates this non-c_glib stuff from your effort and passes both "make check"
and "make cross" locally.
> Improve SSL security in thrift by adding a make cross client that checks to
> make sure SSLv3 protocol cannot be negotiated
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4084
> URL: https://issues.apache.org/jira/browse/THRIFT-4084
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
> Affects Versions: 0.10.0
> Environment: Ubuntu Dockerfile
> Reporter: James E. King, III
> Assignee: James E. King, III
> Labels: cross-validation, security, ssl, tls
>
> Following code review discussions in THRIFT-3369, and seeing THRIFT-3165 in
> the backlog, I want to add a make cross "language" which isn't a language at
> all, but a test that checks to see if it is possible to negotiate at various
> SSL/TLS protocol versions. This would be a client-only test, likely just a
> bash script that leverages the openssl client and command line options to
> connect to a test server and see if it handshakes and negotiates protocol
> successfully.
> Without THRIFT-3165 implemented, it will ensure:
> * Can handshake using the universal SSLv23 context, however cannot negotiate
> SSLv3
> * Can negotiate TLSv1.0, TLSv1.1, and TLSv1.2
> With THRIFT-3165 it needs to change to ensure:
> * Can handshake using TLSv1.2 but not any other version
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
