Github user zertosh commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r101392209
--- Diff: build/docker/debian/Dockerfile ---
@@ -113,8 +113,8 @@ RUN apt-get update && apt-get install -y
--no-install-recommends \
neko-dev \
libneko0
-# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
-RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
+# Node.js dependencies - THRIFT-4064 says it must be >= 0.12.0
--- End diff --
The point was to move away from `ws@<1.0.0`, since those versions depend on
native node modules - they're a huge pain
(https://github.com/apache/thrift/pull/672#issuecomment-276678791). Ideally
we'd upgrade to the latest `ws` (v2.x), but the newer JS syntax is proving to
be really problematic. Less ideally, but nonetheless solves the native module
problem, is to upgrade to `ws@^1.0.0`. That only requires Node >= 0.12.0, and
doesn't use newer syntax.
I still want to use `ws@^2.0.0`, but that requires other upstream dep
fixes. I'm not really familiar with phantomjs, so that's going to take me a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
