Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1191
Discussing with folks who created crosstest what we should do. My
preference is to have a single "multiplexed" protocol test that uses the binary
protocol. That will be the most widely used combo, and layering multiplexed on
top of any other protocol does not test any new functionality of multiplexed;
but it might catch strange interactions that we could miss if we don't test all
of them. I'm not fond of the explosion of the test matrix, doubling all the
tests potentially.
If you look in tests.json you will see protocols like "binary" and then
"binary:accel", also "compact" and "compact:accelc". This naming format
basically says that if crosstest is testing "binary" it will match "binary" and
"binary:accel", however the test wll be run once with a --protocol of "binary"
and once with a --protocol of "accel". I didn't want to add "binary:multi",
"compact:multic", "json:multij", "header:multih" but that would be the logical
extension of the pattern that already exists in crosstest.
So I'm working on a copy of your branch right now to simplify down to
"multiplexed" and then I want to see it run in the crosstest locally. Then
once I hear back from some folks we can move forward if they are okay with the
simplification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
