[ 
https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879927#comment-15879927
 ] 

ASF GitHub Bot commented on THRIFT-4102:
----------------------------------------

GitHub user atiking opened a pull request:

    https://github.com/apache/thrift/pull/1203

    THRIFT-4102 TBufferedTransport performance issue since 0.10.0

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atiking/thrift THRIFT-4102

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1203
    
----

----


> TBufferedTransport performance issue since 0.10.0
> -------------------------------------------------
>
>                 Key: THRIFT-4102
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4102
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.10.0
>            Reporter: Jin Yao
>
> I upgrade thrift from 0.9.3 to 0.10.0, and our rpc calls slow down.
> I digged around the code, and find maybe it caused by the write function in 
> TBufferedTransport.
> The last line seems useless, but cost time.
> {code:title=TTransport.py|borderStyle=solid}
> def write(self, buf):
>     try:
>         self.__wbuf.write(buf)
>         except Exception as e:
>             # on exception reset wbuf so it doesn't contain a partial 
> function call
>             self.__wbuf = BufferIO()
>             raise e
>     self.__wbuf.getvalue() # it seems useless, but cost time
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to