[
https://issues.apache.org/jira/browse/THRIFT-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888648#comment-15888648
]
ASF GitHub Bot commented on THRIFT-4081:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1205
THRIFT-4081: appveyor retooling - build both MSVC2015 and MINGW on appveyor
Also enabled Qt 5.8 for the MSVC build and cleaned up a bunch of smaller
things the MINGW build found.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4081-appveyor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1205
----
commit 63c4a0fdfd75c297d447e31cfeead9187507c034
Author: James E. King, III <[email protected]>
Date: 2017-02-22T20:54:26Z
THRIFT-4081: appveyor retooling - working on msys2/mingw64 as msvc 2010 and
2015 are close to working
----
> Provide a MinGW 64-bit Appveyor CI build for better pull request validation
> ---------------------------------------------------------------------------
>
> Key: THRIFT-4081
> URL: https://issues.apache.org/jira/browse/THRIFT-4081
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Affects Versions: 0.10.0
> Environment: Appveyor
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> We currently build in Visual Studio 2015 on Appveyor. We do not use the
> Windows CI environment to verify that MinGW still builds successfully (there
> is a 32-bit job on linux, #16, which runs on every pull request). I would
> recommend that we add a CI build job to Appveyor and/or extend the existing
> job to build with the latest MinGW 64-bit environment which includes
> gcc-6.3.0; we could perhaps remove Travis job #16 which is using 32-bit mingw
> on linux as a result?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
