[
https://issues.apache.org/jira/browse/THRIFT-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897739#comment-15897739
]
ASF GitHub Bot commented on THRIFT-4108:
----------------------------------------
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/1208
THRIFT-4108 : Fix several problems found on library.
Adjust headers.
Format code.
Make sure finalization is correct.
Fix convenience methods.
Remove global ssl context.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gadLinux/thrift THRIFT-4108
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1208
----
commit 2923765c56e95b1fe93339cc99d8bf7b357f5295
Author: Gonzalo Aguilar Delgado <[email protected]>
Date: 2017-03-06T17:55:44Z
Remove global ssl context.
Adjust headers.
Format code.
Make sure finalization is correct.
Fix convenience methods.
----
> c_glib thrift ssl has multiple bugs and deprecated functions
> ------------------------------------------------------------
>
> Key: THRIFT-4108
> URL: https://issues.apache.org/jira/browse/THRIFT-4108
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Library
> Affects Versions: 1.0
> Reporter: Gonzalo Aguilar
> Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> The function thrift_ssl_socket_finalize_openssl doesn't work because uses a
> deprecated global static variable that should be removed in the latests
> patches. It breaks program
> Specifically the functions thrift_ssl_socket_new_with_host,
> thrift_ssl_socket_new must be removed or refactored.
> But due to the fact that the constructor is not able to get Protocol version
> to be used with SSL, no one can select the protocol for SSL but LATEST is
> always used.
> So it must be addressed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
