Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1212#discussion_r106642062
--- Diff: lib/java/src/org/apache/thrift/transport/THttpClient.java ---
@@ -304,6 +304,9 @@ private void flushUsingHttpClient() throws
TTransportException {
throw new TTransportException(ioe);
}
}
+ if (post != null) {
+ post.releaseConnection();
--- End diff --
The code on line 295 appears to want to take care of this condition.
Perhaps other exceptions are occurring, or something else is happening like
we're not actually consuming all the data that was sent?
From my read of this method "post" will never be null, so the check here
and on line 294 are unnecessary.
I would check into the IOException handler above and see if it needs to be
expanded, perhaps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
