[
https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931531#comment-15931531
]
Aki Sukegawa edited comment on THRIFT-4026 at 3/19/17 2:12 AM:
---------------------------------------------------------------
[~jbapple] In our CI job #8, we're running make check on Python 2.7.6 with
these two packages.
Does {{import ipaddress}} and {{import backports.ssl_match_hostname}} work on
your environment ?
A test case skip logic might be flawed, it only checks availability of
{{ipaddress}} while we need {{match_hostname}} too.
was (Author: nsuke):
[~jbapple] In our CI job #8, we're running make check on Python 2.7.6 with
these two packages.
Does {{import ipaddress}} and {{import backports.ssl_match_hostname}} work on
your environment ?
> TSSLSocket doesn't work with Python < 2.7.9
> -------------------------------------------
>
> Key: THRIFT-4026
> URL: https://issues.apache.org/jira/browse/THRIFT-4026
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.10.0
> Environment: Python 2.7.5
> Reporter: Benoit Sigoure
> Assignee: Aki Sukegawa
> Fix For: 0.11.0
>
>
> As a result of a change made in THRIFT-3917, {{TSSLSocket}} now fails with a
> {{TypeError}} in {{open()}}:
> {code}
> File
> "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py",
> line 293, in open
> self._validate_callback(self.peercert, self._server_hostname)
> TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)
> {code}
> Indeed, {{legacy_validate_callback()}} takes an extra {{self}} argument,
> which cannot possibly be compatible with the signature of
> [{{ssl.match_hostname()}}|https://docs.python.org/3/library/ssl.html#ssl.match_hostname]
> (which was added in Python 3.2).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
