Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106959992
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const { return key_; }
- enum e_req { T_REQUIRED, T_OPTIONAL, T_OPT_IN_REQ_OUT };
+ enum e_req { T_REQUIRED = 0u, T_OPTIONAL, T_OPT_IN_REQ_OUT = ~0u };
--- End diff --
This changes the value of T_OPT_IN_REQ_OUT from before - is this ever on
the wire? Would an older client end up sending "2" here instead of ~0u ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
