Great, thanks for the feedback. I didn't feel comfortable even trying it, so I guess the comment will simply be wrong. At least the fix isn't. 😊
- Jim -----Original Message----- From: Jake Farrell [mailto:jfarr...@apache.org] Sent: Thursday, March 23, 2017 10:06 AM To: dev@thrift.apache.org Subject: Re: git commit --amend fast forward is not allowed on any of the ASF git repos, you either have to do a full revert patch as a second commit or make the necessary modifications and commit that as a new patch -Jake On Wed, Mar 22, 2017 at 8:35 PM, Jim King <jim.k...@simplivity.com> wrote: > I attributed a fix to C++ when it is for Java in the check-in comments > (Client: ). > > Can I do a “git commit –amend” and “git push –force” on master? Is > that acceptable (the force push part)? > > > > [image: hpesimplivitytogether] > > James E. King, III > > HPE SimpliVity > > 8 Technology Drive, 2nd Floor > Westborough, MA 01581-1756 > > Ph: 855-SVT-INFO > > > > > ------------------------------ > PRIVACY STATEMENT: > This message is a PRIVATE communication. This message and all > attachments are a private communication sent by SimpliVity and are > considered to be confidential or protected by privilege. If you are > not the intended recipient, you are hereby notified that any > disclosure, copying, distribution or use of the information contained > in or attached to this message is strictly prohibited. Please notify > the sender of the delivery error by replying to this message, and then delete > it from your system. > For more information please visit http://www.simplivity.com > ------------------------------ > --------------------------------------------------------------------------------------- PRIVACY STATEMENT: This message is a PRIVATE communication. This message and all attachments are a private communication sent by SimpliVity and are considered to be confidential or protected by privilege. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the information contained in or attached to this message is strictly prohibited. Please notify the sender of the delivery error by replying to this message, and then delete it from your system. ---------------------------------------------------------------------------------------
