[
https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942370#comment-15942370
]
ASF GitHub Bot commented on THRIFT-4136:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1221
> Align is_binary() method with is_string() to simplify those checks
> ------------------------------------------------------------------
>
> Key: THRIFT-4136
> URL: https://issues.apache.org/jira/browse/THRIFT-4136
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.11.0
>
>
> Similar to {{is_string()}} the {{is_binary()}} method should be virtual and
> implemented at {{t_type}}. This simplifies the code and reduces possibilities
> for making technically wrong casts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
