[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952372#comment-15952372
]
ASF GitHub Bot commented on THRIFT-4154:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1233
THRIFT-4154: properly close socket whether it is persistent or not on
close()
Replaces PR #1011. Resubmitting to get a CI build that passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1233
----
commit a48781a52d9f79c290c153830cf1ee48348b9a67
Author: James E. King, III <[email protected]>
Date: 2017-04-01T19:57:36Z
THRIFT-4154: properly close socket whether it is persistent or not on
close()
----
> PHP close() of a TSocket needs to close any type of socket
> ----------------------------------------------------------
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
