[
https://issues.apache.org/jira/browse/THRIFT-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959576#comment-15959576
]
ASF GitHub Bot commented on THRIFT-4170:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1241
THRIFT-4170: re-submitting PR #669 to fix lua backwards compatibility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit 855fffa7738f4ba6c4bd80911a93ea8cb04ab91e
Author: James E. King, III <[email protected]>
Date: 2017-04-06T19:24:53Z
THRIFT-4170: re-submitting PR #669 to fix lua backwards compatibility
----
> Support lua 5.1 or earlier properly for object length determination
> -------------------------------------------------------------------
>
> Key: THRIFT-4170
> URL: https://issues.apache.org/jira/browse/THRIFT-4170
> Project: Thrift
> Issue Type: Bug
> Components: Lua - Library
> Affects Versions: 0.10.0
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> I found an old, small PR in the backlog
> (https://github.com/apache/thrift/pull/669) and it has a trivial change that
> is more correct than the solution in the codebase right now. I'm going to
> submit it as a new PR.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
