[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959636#comment-15959636
]
ASF GitHub Bot commented on THRIFT-3627:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1243
THRIFT-3627 fix missing basic code style consistency of JavaScript.
The original PR #858 is over a year old; there are no merge conflicts, but
I want to make sure it still passes all the CI builds and tests before
committing it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-3627-resubmit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1243
----
commit 648681b148b1ec79eaefee25e92ee590b9171348
Author: Kazuki Matsuda <[email protected]>
Date: 2016-02-13T10:36:09Z
THRIFT-3627 fix missing basic code style consistency of JavaScript.
----
> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
> Reporter: Kazuki Matsuda
> Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
